fix disk size SRU in filters of the grid nightly scripts #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Harby
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
1 task
amiraabouhadid
approved these changes
Jun 5, 2024
| @@ -30,7 +30,7 @@ async function main() { | |||
| const vmQueryOptions: FilterOptions = { | |||
| cru: 1, | |||
| mru: 1, // GB | |||
| sru: 1, | |||
| sru: 5, | |||
There was a problem hiding this comment.
the rootfs is 0 and nothing is added for it, but zos will calculate it based on cpu and memory with a max of 2 GB. So as a guard, add 2 GB for the rootfs
There was a problem hiding this comment.
I added an extra 2 GB for every script in the grid nightly to cover cases of rootfs.
AlaaElattar
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
small fix in the SRU filter in the nightly test.
I tested it and test passed on dev https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/9371629473/job/25801291189.
Related Issues
#2750
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist